Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pizza project - Jenny Andersén #154

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Conversation

jempa182
Copy link

@jempa182 jempa182 commented Sep 8, 2024

Copy link
Contributor

@HIPPIEKICK HIPPIEKICK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wohooo, great job on putting together your pizza order JavaScript project! 🍕

JavaScript

  • consider using template literals (backticks `) consistently for easier readability, like you did for the alert in Step 4. That would look like:
alert(`Hello ${name}!`);
  • Nice usage of parseInt() to ensure valid user inputs ⭐

Clean Code

  • As mentioned, you're already using template literals in some places. Keep it consistent for better readability across the entire code.
  • Consider using even more descriptive variable names, such as instead of whatKind, you could name it dishChoice or something
  • Indentations look clean and your code is easy to follow!

Keep up the good work Jenny ⭐

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants